Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure icons for image/video are SVG components #15863

Merged
merged 1 commit into from
May 30, 2019
Merged

Ensure icons for image/video are SVG components #15863

merged 1 commit into from
May 30, 2019

Commits on May 28, 2019

  1. Ensure icons for image/video are SVG components 

    In #15551, these were changed to support passing props, but that also means
that when you pass the video icon to the `Icon` component, it won't inject the
right size, since it's not a SVG component.

Instead, we can export the new function to allow for a customizable icon, while
exporting the SVG component by default.
    @koke
    koke committed May 28, 2019
    Configuration menu
    Copy the full SHA
    25bf193 View commit details
    Browse the repository at this point in the history