Correct text zoom issue in the Content Structure popover #15984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Focus] Accessibility (a11y)
afercia
reviewed
Jun 13, 2019
There was a problem hiding this comment.
@kjellr thanks! Screenshot including some the first heading in the content structure popover, from Firefox with zoom > text only at very high level:
Looks good to me: the text doesn't overlap.
Ideally, the popover width should be able to adjust a bit depending on the available space. Something like a "range" between a min and max width maybe. Not sure if that would impact the calculation of the popover position which is done via JavaScript. If possible, I'd encourage some exploration in that direction 🙂
The build fails, not sure why.
jorgefilipecosta
approved these changes
Jun 24, 2019
|
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15357.
As noted in the issue, text in the Content Structure popover currently overlaps when using the browser's text zoom feature. This PR switches the fixed percentage width to use the somewhat more flexible
flex-basisinstead. It also adds a tiny bit of spacing in between each item.Before
Viewed at 100%
Viewed at 200%
After
Viewed at 100% (No changes)
Viewed at 200%