Docs: Change register_meta to register_post_meta #16032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soean
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
notnownikki and
youknowriad
as code owners
mkaz
approved these changes
Jun 7, 2019
There was a problem hiding this comment.
Looks good!
Confirmed by reading the core documentation, it looks like the corresponding relevant piece is: https://developer.wordpress.org/reference/functions/register_meta/
It is recommended to register meta keys for a specific combination of object type and object subtype.
Using register_post_meta automatically registers the subtype, while register_meta requires passing in object subtype which the examples were not.
|
I'd missed this PR, and was delighted to discover the docs were updated while referencing this section just now. 🎊 🎉 thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the function
register_metatoregister_post_meta(added in WP 4.9.8) in the docs. This function is more specific and intuitive for developers. Fore more details see #16025Fixes #16025