Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block API: Downgrade convert API to experimental #16047

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Jun 7, 2019

Related: #15972, #14908

This pull request seeks to rename the convert transform function introduced in #14908 to be marked as experimental (see relevant documentation), pending further consideration for how it be named or implemented.

Testing Instructions:

Repeat Testing Instructions from #14908, verifying no regressions in the behavior of block grouping / ungrouping.

@aduth aduth added [Feature] Block API API that allows to express the block paradigm. [Release] Do Not Punt Used to indicate the issue or pull request must not be moved from the assigned milestone labels Jun 7, 2019
@aduth aduth added this to the Gutenberg 5.9 milestone Jun 7, 2019
@aduth aduth requested a review from nerrad June 7, 2019 16:00
Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks fine. I'm unable to test to confirm the fix at the moment, but if needed I can do it later today.

@aduth aduth merged commit 28eb941 into master Jun 7, 2019
@aduth aduth deleted the update/transform-convert-experimental branch June 7, 2019 17:46
@getdave
Copy link
Contributor

getdave commented Jun 11, 2019

Good to see this. Probably safest given the uncertainty around naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Release] Do Not Punt Used to indicate the issue or pull request must not be moved from the assigned milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants