Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] iOS Image block caption multiline fix #16071

Merged
merged 2 commits into from
Jun 10, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Jun 10, 2019

This PR fixes an issue on iOS where pressing Enter on a Image Block's caption field, it won't do anything.

It should append a <br> tag and create a new line.

gutenberg-mobile side PR: wordpress-mobile/gutenberg-mobile#1107

To test:

  • Run the example project.
  • Select the Image block with content.
  • Write something in the caption field.
  • Press enter,
  • Check that a new line is created.
  • Switch to HTML mode.
  • Check that the new line was created by appending a <br> tag.

@etoledom etoledom self-assigned this Jun 10, 2019
@etoledom etoledom added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jun 10, 2019
@etoledom etoledom marked this pull request as ready for review June 10, 2019 13:36
@SergioEstevao
Copy link
Contributor

Press enter,

or press Shift+Enter ?

@etoledom
Copy link
Contributor Author

or press Shift+Enter ?

A single Enter should make a new line on the Image Caption field by appending a br tag. That's how web works.

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! Good catch!

@etoledom etoledom merged commit 4d08cc5 into master Jun 10, 2019
@etoledom
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants