Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct group icon prop names #16096

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Correct group icon prop names #16096

merged 1 commit into from
Jun 11, 2019

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Jun 11, 2019

As noted by @aduth in #16001 (review), the Group icons currently have clip-rule and fill-rule attributes that are improperly named. If WP's SCRIPT_DEBUG constant is set to true, you'll see errors like the following:

Warning: Invalid DOM property fill-rule. Did you mean fillRule?
Warning: Invalid DOM property clip-rule. Did you mean clipRule?

This PR changes those to fillRule and clipRule, eliminating the warning.

@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Block] Group Affects the Group Block labels Jun 11, 2019
@kjellr kjellr requested a review from aduth June 11, 2019 20:48
@kjellr kjellr self-assigned this Jun 11, 2019
@kjellr kjellr mentioned this pull request Jun 11, 2019
Merged
aduth
aduth approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks 👍

For what it's worth, once #14845 is implemented / closed, these issues will be harder to introduce inadvertently. We should be able to leverage our automated testing to prevent this.

@kjellr kjellr merged commit 6156365 into master Jun 11, 2019
@kjellr kjellr deleted the update/group-icon-property-names branch June 11, 2019 21:10
@gziolo gziolo added this to the Gutenberg 6.0 milestone Jun 12, 2019
This was referenced Jul 16, 2024
Open
Open
@OKEAMAH OKEAMAH mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@notnownikki notnownikki Awaiting requested review from notnownikki

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@kjellr kjellr

Labels
[Block] Group Affects the Group Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kjellr @aduth @gziolo