[RNMobile] Release v1.6.0 #16108
Closed
[RNMobile] Release v1.6.0 #16108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #15551, these were changed to support passing props, but that also means that when you pass the video icon to the `Icon` component, it won't inject the right size, since it's not a SVG component. Instead, we can export the new function to allow for a customizable icon, while exporting the SVG component by default.
hypest
added
the
Mobile App - i.e. Android or iOS
hypest
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
|
Closing because we won't merge it to master. See PR description above. The release is tagged as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks the release v1.6.0 of the native mobile app.
We will not merge this one actually since the code it includes was only meant as a quick-fix until a more proper (and mergeable) fix happened. See #15863 (comment).