Remove: experimental status from blockEditor.transformStyles #16126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Code Quality
jorgefilipecosta
requested review from
ajitbohra,
ellatrix,
gziolo,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
jorgefilipecosta
force-pushed
the
remove/experimental-status-from-transform-styles
branch
from
61bc34f
to
0498555
Compare
aduth
reviewed
Jun 25, 2019
packages/block-editor/README.md
Outdated
| @@ -387,6 +387,10 @@ _Type_ | |||
|
|
|||
| - `Object` | |||
|
|
|||
| <a name="transformStyles" href="#transformStyles">#</a> **transformStyles** | |||
|
|
|||
| Internal dependencies | |||
There was a problem hiding this comment.
This isn't accurate documentation. I think we should use the "Internal dependencies" text only for import, whereas we're using it as export currently.
I'd suggest:
- Remove the "Internal dependencies" DocBlock
- Add sufficient documentation for
transformStyles
There was a problem hiding this comment.
Suggestion applied 👍
jorgefilipecosta
force-pushed
the
remove/experimental-status-from-transform-styles
branch
from
0498555
to
2d423e9
Compare
aduth
approved these changes
Jun 27, 2019
jorgefilipecosta
deleted the
remove/experimental-status-from-transform-styles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up on #15572.
Removes experimental status from blockEditor.transformStyles.
How has this been tested?
I verified the HTML block still works as before.
I executed wp.blockEditor.transformStyles( [ { css: 'h1, b { color: red; }' } ], '.wp' );in the browser console and I verified the output was: [".wp h1,↵.wp b {↵color: red;↵}"].