Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HTML anchor explaination text #16142

Merged
merged 11 commits into from
Jul 8, 2019
Merged

Update HTML anchor explaination text #16142

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ad4b2cb
Update HTML anchor explaination text
melchoyce Jun 13, 2019
075cda4
Update "learn more" class name to fit the component
melchoyce Jun 13, 2019
94d3ccb
Wrap sentence in paragraph to inherit the correct styles
melchoyce Jun 13, 2019
1c3f9df
Fix indentation issues
melchoyce Jun 13, 2019
ae2b1c7
Fix "you'll" parsing error
melchoyce Jun 13, 2019
a8dfefb
Change div to p
melchoyce Jun 13, 2019
634221d
Update packages/block-editor/src/hooks/anchor.js
melchoyce Jun 20, 2019
22cd081
Update packages/block-editor/src/hooks/anchor.js
melchoyce Jul 4, 2019
a77fe87
Added stylesheet for anchor.
tellthemachines Jul 5, 2019
aec4d12
Update link.
tellthemachines Jul 5, 2019
3bafcf8
No need to localise link URLs
noisysocks Jul 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/block-editor/src/hooks/anchor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { assign, has } from 'lodash';
* WordPress dependencies
*/
import { addFilter } from '@wordpress/hooks';
import { TextControl } from '@wordpress/components';
import { TextControl, ExternalLink } from '@wordpress/components';
import { __ } from '@wordpress/i18n';
import { hasBlockSupport } from '@wordpress/blocks';
import { createHigherOrderComponent } from '@wordpress/compose';
Expand Down Expand Up @@ -70,8 +70,17 @@ export const withInspectorControl = createHigherOrderComponent( ( BlockEdit ) =>
<BlockEdit { ...props } />
<InspectorAdvancedControls>
<TextControl
className="html-anchor-control"
label={ __( 'HTML Anchor' ) }
help={ __( 'Anchors lets you link directly to a section on a page.' ) }
help={ (
<>
{ __( 'Enter a word or two — without spaces — to make a unique web address just for this heading, called an “anchor.” Then, you’ll be able to link directly to this section of your page.' ) }

<ExternalLink href={ __( 'https://wordpress.org/support/article/page-jumps/' ) }>
{ __( 'Learn more about anchors' ) }
</ExternalLink>
</>
) }
value={ props.attributes.anchor || '' }
onChange={ ( nextValue ) => {
nextValue = nextValue.replace( ANCHOR_REGEX, '-' );
Expand Down
4 changes: 4 additions & 0 deletions packages/block-editor/src/hooks/anchor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.html-anchor-control .components-external-link {
display: block;
margin-top: $grid-size;
}
1 change: 1 addition & 0 deletions packages/block-editor/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@
@import "./components/url-popover/style.scss";
@import "./components/warning/style.scss";
@import "./components/writing-flow/style.scss";
@import "./hooks/anchor.scss";