Editor: Fix the issue where statics for deprecated components were not hoisted #16152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
commented
Jun 13, 2019
| @@ -41,7 +41,6 @@ import { | |||
| RichText as RootRichText, | |||
| RichTextShortcut as RootRichTextShortcut, | |||
| RichTextToolbarButton as RootRichTextToolbarButton, | |||
| RichTextInserterItem as RootRichTextInserterItem, | |||
There was a problem hiding this comment.
There is no such component in @wordpress/block-editor ...
gziolo
added
[Type] Regression
|
Is it something to consider this project, so we don't need to risk human error in specifying individual static properties to hoist? |
I considered it but I decided that it isn't that much useful in this context because of that whitelisted statics hoisted need to have deprecation logic applied as well. The library you shared only hoists statics and leaves them unchanged. |
youknowriad
approved these changes
Jun 13, 2019
kellymears
added a commit
to pixelcollective/laravel-mix-wp-blocks
that referenced
this pull request
Jun 14, 2019
gziolo
added a commit
that referenced
this pull request
Jun 14, 2019
daniloercoli
added a commit
that referenced
this pull request
Jun 14, 2019
…rnmobile/open-video-by-browser-for-android * 'master' of https://github.com/WordPress/gutenberg: (34 commits) [RNMobile] Native mobile release v1.7.0 (#16156) Scripts: Document and simplify changing file entry and output of build scripts (#15982) Block library: Refactor Heading block to use class names for text align (#16035) Make calendar block resilient against editor module not being present (#16161) Bump plugin version to 5.9.1 Editor: Fix the issue where statics for deprecated components were not hoisted (#16152) Build Tooling: Use "full" `npm install` for Build Artifacts Travis task (#16166) Scripts: Fix naming conventions for function containing CLI keyword (#16091) Add native support for Inserter (Ported from gutenberg-mobile) (#16114) docs(components/higher-order/with-spoken-messages): fix issue in example code (#16144) docs(components/with-focus-return): fix typo in README.md (#16143) docs(block-editor/components/inspector-controls): fix image path in README.md (#16145) Add mention of on Figma to CONTRIBUTING.md (#16140) Bring greater consistency to placeholder text for media blocks. (#16135) Add descriptive text and a link to embed documentation in embed blocks (#16101) Update toolbar-text.png (#16102) Updating changelogs for the Gutenberg 5.9 packages release chore(release): publish [RNMobile] Fix pasting text on Post Title (#16116) Bump plugin version to 5.9.0 ... # Conflicts: # packages/block-library/src/video/video-player.android.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue was discovered in Jetpack plugin, see Automattic/jetpack#12673.
There are a few components which were moved to
@wordpress/block-editorpackage which were marked as deprecated. Unfortunately, they no longer expose statics exposed in the original components. Example:wp.blockEditor.InnerBlocksexposes also,wp.blockEditor.InnerBlocks.ContentThere was only
wp.editor.InnerBlocksexposed for backward compatibility which obviously breaks the code in some plugins. This PR fixes it by exposing also missed statics.How has this been tested?
Open JS console and ensure that all statics are hoisted:
BlockControls.SlotBlockFormatControls.SlotInnerBlocks.ContentInspectorAdvancedControls.SlotInspectorControls.SlotRichText.ContentRichText.isEmpty