Fix/add check for null in gutenberg is block editor function #16201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myleshyson
requested review from
aduth,
gziolo,
TimothyBJacobs and
youknowriad
as code owners
|
Seems reasonable to check whether the current screen is actually defined and not null. 👍 |
|
https://developer.wordpress.org/reference/functions/get_current_screen/ Sounds good. Not sure why there are e2e test errors? Perhaps a rebase resolves them? |
gziolo
added
[Type] Code Quality
|
Previously: #15983, #15209 (cc @jorgefilipecosta) It's a good additional hardening to consider, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses #16199. Adds a null check in the
gutenberg_is_block_editorfunction so that we can avoid unexpected errors.How has this been tested?
We are using the mailpoet plugin which utilizes wp_iframe (where this error is occuring). I added this check and the plugin works like it should now.
Types of changes
A very small quick fix to avoid a unexpected 500 error.
Fixes #16199.