Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Gallery Settings Sidebar when editing gallery #1623

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Jun 30, 2017

Fixes #1447
Add attribute displaySettings=false to editFrame to suppress sidebar. The frameConfig settings did not pass forward to the different states of the modals, so it was required to set the attribute after creating the editFrame.

The frameConfig settings did not pass forward to the different states of
the modals, so it was required to set the attribute after creating the
editFrame.
@mkaz mkaz changed the title Add attribute displaySettings=false to editFrame to suppress sidebar Suppress Gallery Settings Sidebar when editing gallery Jun 30, 2017
@mkaz mkaz added the [Feature] Media Anything that impacts the experience of managing media label Jun 30, 2017
@georgeh
Copy link
Contributor

georgeh commented Jul 5, 2017

:shipit:

Tested and confirmed the gallery settings are no longer visible when editing galleries.

@mkaz mkaz merged commit 5ce605c into master Jul 5, 2017
@mkaz mkaz deleted the fix/1447-gallery-settings branch July 5, 2017 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants