Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snackbar notification for "Copy All Content #16265

Merged
merged 3 commits into from
Jun 25, 2019
Merged

Snackbar notification for "Copy All Content #16265

merged 3 commits into from
Jun 25, 2019

Conversation

Soean
Copy link
Member

@Soean Soean commented Jun 24, 2019

Description

Adds a snackbar notification for "Copy All Content".
Fixes #16261

copied

@Soean Soean requested review from youknowriad and mtias June 24, 2019 16:03
@Soean Soean requested a review from talldan as a code owner June 24, 2019 16:03
@Soean Soean self-assigned this Jun 24, 2019
@Soean Soean added the [Feature] UI Components Impacts or related to the UI component system label Jun 24, 2019
jorgefilipecosta
jorgefilipecosta approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good and it works well on my tests. Thank you for improving this feature 👍

@youknowriad
Copy link
Contributor

youknowriad commented Jun 24, 2019 •
edited
Loading

Makes me wonder if we want to close the menu as well. There might be some a11y/design issues if we decide to close the menu, so worth checking.

@Soean Soean added the Needs Accessibility Feedback Need input from accessibility label Jun 24, 2019
@Soean
Copy link
Member Author

Soean commented Jun 24, 2019

Makes me wonder if we want to close the menu as well. There might be some a11y/design issues if we decide to close the menu, so worth checking.

I think it's a good idea. I added the label to get feedback from the A11y team.

@mtias
Copy link
Member

mtias commented Jun 25, 2019

Looks good to me. I think the question about whether the menu should close after the interaction can be asked as a new issue, too.

@mtias mtias self-requested a review June 25, 2019 08:45
@Soean Soean removed the Needs Accessibility Feedback Need input from accessibility label Jun 25, 2019
@Soean Soean mentioned this pull request Jun 25, 2019
Closed
@Soean
Copy link
Member Author

Soean commented Jun 25, 2019

Thanks, I opened #16279 for this enhancement. When the tests pass, we can merge this PR.

@Soean Soean merged commit 736adf3 into master Jun 25, 2019
@Soean Soean deleted the update/copied-notice branch June 25, 2019 10:15
@Soean Soean mentioned this pull request Jun 25, 2019
Closed
@youknowriad youknowriad added this to the Gutenberg 6.1 milestone Jul 5, 2019
This was referenced Jul 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@mtias mtias mtias approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

@talldan talldan Awaiting requested review from talldan

Assignees

@Soean Soean

Labels
[Feature] UI Components Impacts or related to the UI component system
Projects
None yet
Milestone
Gutenberg 6.1
Development

Successfully merging this pull request may close these issues.

"Copy All Content" should trigger a snackbar notification
4 participants
@Soean @youknowriad @mtias @jorgefilipecosta