Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to allow alternative Blocks to handle Grouping interactions #16278

Merged
merged 10 commits into from
Jul 9, 2019
Merged

Update to allow alternative Blocks to handle Grouping interactions #16278

merged 10 commits into from
Jul 9, 2019

Commits on Jul 9, 2019

  1. Updates factory util to reference registered Grouping Block 

    Previously the method that determined whether a given Block was the block to be used for “Grouping” interactions was hardcoded as “core/group” within `isContainerBlock`. Updated to utilise the registered Grouping Block in order to allow alternative Blocks to be utilised for Grouping.
    @getdave
    getdave committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    8e9e9f0 View commit details
    Browse the repository at this point in the history

  2. Attempt e2e test to validate usage of alternate Block for grouping 

    Currently this doesn’t work because window doesn’t have NODE defined.
    @getdave
    getdave committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    ba639af View commit details
    Browse the repository at this point in the history

  3. Adds e2e test to confirm ability to register alternative Block for Gr… 

    …ouping

Now using custom Gutenberg Plugin. Currently failing as the test Block appears to be unavailable within the Editor and doesn’t pass the `canInsertBlockType` test.
    @getdave
    getdave committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    1088ae8 View commit details
    Browse the repository at this point in the history

  4. Utilise withSelect to get the current Grouping Block name

    @getdave
    getdave committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    fb436d5 View commit details
    Browse the repository at this point in the history

  5. Removes unrequired test suite

    @getdave
    getdave committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    9ccb877 View commit details
    Browse the repository at this point in the history

  6. Fix bug with misnamed variable

    @getdave
    getdave committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    0f63a67 View commit details
    Browse the repository at this point in the history

  7. Remove hardcoded group block ref 

    Addresses #16278 (review)
    @getdave
    getdave committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    37d5ab0 View commit details
    Browse the repository at this point in the history

  8. Remove / update refs to core/group within comments

    @getdave
    getdave committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    c7339a6 View commit details
    Browse the repository at this point in the history

  9. Block API: Stub default attributes, keywords values for block type re… 

    …gistration
    @aduth
    aduth committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    be6e767 View commit details
    Browse the repository at this point in the history

  10. Revert "Block API: Stub default attributes, keywords values for block… 

    … type registration"

This reverts commit be6e767.
    @aduth
    aduth committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    d53afc1 View commit details
    Browse the repository at this point in the history