WIP: optimize get block selector #16368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of custom sources
youknowriad
added
[Status] In Progress
youknowriad
requested review from
aduth,
ajitbohra,
chrisvanpatten,
ellatrix,
gziolo,
mkaz,
nerrad,
ntwb and
talldan
as code owners
youknowriad
force-pushed
the
try/optimize-get-block-selector
branch
from
9ce5de3
to
2f9b63e
Compare
|
Without having looked at this in too much depth, I think the "parents" refactoring alone is a worthwhile refactor that likely has some optimization gain, and could maybe be split from the cachebust work. It's one I've been thinking about for a while, since the original implementation of blocks state did not optimize for parents traversal (it was not as common at the time, but is quite frequently used in selectors nowadays). |
|
@aduth definitely, I was also thinking about extracting it to its own PR 👍 |
This was referenced Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #16075 and tries to improve the memoization of the getBlock selector by relying on denormalized reducer.
Still very early for a review, but I need to run the tests, so I'm opening a PR.