Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid a console warning when running performance tests #16409

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Avoid a console warning when running performance tests #16409

merged 1 commit into from
Jul 4, 2019

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Jul 3, 2019 •
edited
Loading

We were using a deprecated API triggering a console warning.

Testing instructions

  • run npm run test-performance
  • the job should not show an error.

@youknowriad youknowriad self-assigned this Jul 3, 2019
@youknowriad youknowriad added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Jul 3, 2019
nerrad
nerrad approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly straightforward. Moige it 👍

@nerrad
Copy link
Contributor

nerrad commented Jul 3, 2019

Ooops... sorry I missed that you had labelled this "good first review" and I jumped in too soon :).

@youknowriad youknowriad merged commit 2bb3d5a into master Jul 4, 2019
@github-actions github-actions bot added this to the Gutenberg 6.1 milestone Jul 4, 2019
@youknowriad youknowriad deleted the fix/performance-test branch July 4, 2019 09:37
This was referenced Jul 16, 2024
Open
Open
@OKEAMAH OKEAMAH mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerrad nerrad nerrad approved these changes

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@ntwb ntwb Awaiting requested review from ntwb

@talldan talldan Awaiting requested review from talldan

Assignees

@youknowriad youknowriad

Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowriad @nerrad