-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the use of tabs for list indents and outdents #1641
Allow the use of tabs for list indents and outdents #1641
Conversation
As mentioned in #1552 this would break keyboard navigation through blocks 🚨 Once in a "list" block there's no way to tab away from the block, since the Tab key is used for indentation. |
Yep but then it would be unexpected that tabbing works for some blocks and doesn't for some other ones? |
Worth noting that this breaks in TinyMCE as well. Tab will normally focus the next focusable element, except in lists. Not sure what the solution is here. Could it work only at the start of a list item, and use wp speak to alert the user? Just tried it in Google Docs and there it also only works at the start of a list item. Everywhere else it inserts an actual tab character. |
Yep this always worked this way in TinyMCE too. However, in TinyMCE there are no "blocks" so it is always possible to enter some content after the list (even just a space) and the Tab key switches back to its default action. |
We added the |
See #1826 |
It looks like using new keyboard shortcuts is the way to go here. @DevinWalker thanks for spending time on this PR. I'm closing it, but feel free to reopen if you think it's still an issue. |
PR Overview
Allow
tab
to be used to indent list items. As well, allowshift
+tab
to outdent tabs.Preview
Ref: #1552 and #1640