Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Components] resolve missing styles from checkbox-control component (#11089) #16551

Merged
merged 4 commits into from
Aug 1, 2019
Merged

[UI Components] resolve missing styles from checkbox-control component (#11089) #16551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdbc8fd
[UI Components] resolve missing styles from checkbox-control (#11089)
jffng Jul 9, 2019
39c750f
Use existing Dashicon component
jffng Jul 12, 2019
4958ad0
Merge branch 'master' into fix/checkbox-missing-styling
jffng Jul 12, 2019
adba645
Strip the comments regarding windows high contrast mode from compiled…
jffng Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/components/src/checkbox-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { withInstanceId } from '@wordpress/compose';
* Internal dependencies
*/
import BaseControl from '../base-control';
import Dashicon from '../dashicon';

function CheckboxControl( { label, className, heading, checked, help, instanceId, onChange, ...props } ) {
const id = `inspector-checkbox-control-${ instanceId }`;
Expand All @@ -25,6 +26,7 @@ function CheckboxControl( { label, className, heading, checked, help, instanceId
{ ...props }
/>
<label className="components-checkbox-control__label" htmlFor={ id }>
{ checked ? <Dashicon icon="yes" className="components-checkbox-control__checked" role="presentation" /> : null }
{ label }
</label>
</BaseControl>
Expand Down
71 changes: 70 additions & 1 deletion packages/components/src/checkbox-control/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,72 @@
.components-checkbox-control__input[type="checkbox"] {
margin-top: 0;
border: 1px solid #b4b9be;
background: #fff;
color: #555;
clear: none;
cursor: pointer;
display: inline-block;
line-height: 0;
height: 16px;
margin: 0 4px 0 0;
outline: 0;
padding: 0 !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone else reviewing this, this whole green section is largely copied from http://localhost:8888/wp-admin/css/forms.css?ver=5.2.2, so it is as it says on the bin, a copy of the CSS from wp-admin. So while it would be nice to refactor away the !important, this is a separate task bringing these components to all of wp-admin.

text-align: center;
vertical-align: middle;
width: 16px;
min-width: 16px;
-webkit-appearance: none;
box-shadow: inset 0 1px 2px rgba(0, 0, 0, 0.1);
transition: 0.05s border-color ease-in-out;

&:focus {
border-color: #5b9dd9;
box-shadow: 0 0 2px rgba(30, 140, 190, 0.8);
// Only visible in Windows High Contrast mode.
outline: 2px solid transparent;
}

&:checked {
background: #11a0d2;
border-color: #11a0d2;
}

&:focus:checked {
border: none;
}

&:checked::before {
content: none;
}
}

.components-checkbox-control__label {
position: relative;
vertical-align: middle;
line-height: 1;
}

svg.dashicon.components-checkbox-control__checked {
width: 21px;
height: 21px;
fill: #fff;
cursor: pointer;
position: absolute;
left: -31px;
bottom: -3px;
user-select: none;
pointer-events: none;
}

@media screen and ( max-width: 728px ) {
.components-checkbox-control__input[type="checkbox"] {
width: 25px;
height: 25px;
}

svg.dashicon.components-checkbox-control__checked {
width: 31px;
height: 31px;
left: -41px;
bottom: -9px;
}
}