Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try: Always collapse block alignments. #16557

Merged
merged 5 commits into from
Jul 26, 2019
Merged

Try: Always collapse block alignments. #16557

merged 5 commits into from
Jul 26, 2019

Commits on Jul 25, 2019

  1. Try: Always collapse block alignments. 

    This PR makes the block alignments always be collapsed. This group would already collapse at mobile responsive breakpoints. In addition, this PR also adds a dropdown arrow.

This comes with a couple of benefit:

- It ensures that the block toolbar always fits even when the item is deeply nested inside columns.
- It affords a scalable method to show additional alignment options, such as those suggested in #16385.
- It scales to future ideas of allowing a theme to create CSS grid-based layouts, which could allow theme authors to create their own custom alignments such as "pull right" or others.
- It has labels, to be descriptive of such new alignments.

Noting that 3 is just an idea at this point, but the other items on the list can potentially benefit us today.
    @gziolo
    Joen Asmussen authored and gziolo committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    4ee5511 View commit details
    Browse the repository at this point in the history

  2. Refactor alignment toolbars to be collapsed by default

    @gziolo
    gziolo committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    0675b8f View commit details
    Browse the repository at this point in the history

  3. Add arrow indicator to the Edit tabel dropdown menu

    @gziolo
    gziolo committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    122051c View commit details
    Browse the repository at this point in the history

  4. Update snapshot tests to work with updated components

    @gziolo
    gziolo committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    8a1d9e7 View commit details
    Browse the repository at this point in the history

  5. Update failing e2e tests to work after UI changes introduced

    @gziolo
    gziolo committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    66a5518 View commit details
    Browse the repository at this point in the history