Clean up Gallery block move/remove UI #16793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Bug
kjellr
requested review from
ajitbohra,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
oandregal
reviewed
Jul 30, 2019
| @@ -19,7 +19,7 @@ ul.wp-block-gallery { | |||
| outline: none; | |||
| } | |||
|
|
|||
| .is-selected { | |||
| > .is-selected { | |||
There was a problem hiding this comment.
This works and I'm fine with it. Wanted to run by you a different approach to see what you think: figure.is-selected (I'd also apply this to the is-transient rule below for clarification). Those seem to be the only two rules that don't have a block/element class along with the modifier class.
There was a problem hiding this comment.
Sure, that makes sense. I'll push a quick update to do that.
oandregal
approved these changes
Jul 30, 2019
|
Thanks, everyone! |
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Use larger buttons when we can. * Avoid adding selected border to the caption section of the image. * Remove hover/focus box shadows because they clash with the blue background. * Revise method of specifying the .is-selected class.
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Use larger buttons when we can. * Avoid adding selected border to the caption section of the image. * Remove hover/focus box shadows because they clash with the blue background. * Revise method of specifying the .is-selected class.
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tidies up a couple small visual bugs with the Gallery block's individual image controls. It also switches the buttons to appear larger when possible. This is helpful (especially on mobile) to create a more visible hit area for these previously-tiny controls.
1. Button size improvements:
Before
After
The buttons increase from 20 to 24px. Note that on larger screens, these buttons will shrink back down if there are more than 7 columns present. Is to prevent overlap:
2. Clean up extra
is-selectedborder on the caption field.I'm not sure when this made its first appearance, but I believe it's unintentional?
Before
After
3. Removes box shadow from move/remove controls on hover and focus
These borders weren't working against the blue background.
Before
After