Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose BlockPreview component #16834

Merged
merged 4 commits into from
Aug 2, 2019
Merged

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Jul 31, 2019

Description

This PR exposes the BlockPreview component in order to make it available to be consumed by other plugins.

This branch has been created from update/unify-block-preview-components

How has this been tested?

A simple way to confirm whether the function is being exposed is trying to get it from the console of your dev browser. Type wp.blockEditor and look up the BlockPreview among the other components. Without these changes, the BlockPreview shouldn't be there.

image

Types of changes

Expose the BlockPreview component.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@retrofox retrofox changed the title block-editor: expose BlockPreview block block-editor: expose BlockPreview component Jul 31, 2019
@retrofox retrofox force-pushed the update/expose-block-preview branch from 823b006 to 5dfe9a0 Compare July 31, 2019 12:30
@marekhrabe marekhrabe force-pushed the update/unify-block-preview-components branch from 097bc0f to 3251ebd Compare July 31, 2019 17:22
@obenland obenland force-pushed the update/expose-block-preview branch 2 times, most recently from b354d9f to ac56950 Compare August 2, 2019 17:23
@gwwar gwwar changed the base branch from update/unify-block-preview-components to master August 2, 2019 17:54
@gwwar
Copy link
Contributor

gwwar commented Aug 2, 2019

Changed target to master as requested by @obenland

@retrofox retrofox marked this pull request as ready for review August 2, 2019 18:01
@marekhrabe
Copy link
Contributor

Rebased and updated readme to reflect current props — only isScaled. I intentionally didn't give too much details about the scaling method as that is about to change very soon and more in-depth documentation will be part of that change.

@marekhrabe marekhrabe merged commit fecd838 into master Aug 2, 2019
@marekhrabe marekhrabe deleted the update/expose-block-preview branch August 2, 2019 20:23
@obenland obenland changed the title block-editor: expose BlockPreview component Expose BlockPreview component Aug 8, 2019
@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019
gziolo pushed a commit that referenced this pull request Aug 29, 2019
* block-editor: expose BlockPreview block

* block-preview: add README file. props to @jasmussen and @getdate

* match readme with current functionality

* move doc comment so it is picked up by the generator
gziolo pushed a commit that referenced this pull request Aug 29, 2019
* block-editor: expose BlockPreview block

* block-preview: add README file. props to @jasmussen and @getdate

* match readme with current functionality

* move doc comment so it is picked up by the generator
@nerrad nerrad mentioned this pull request Jan 12, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants