Fix(eslint-plugin): misc bugfixes related to recent jsdoc changes #16975
Conversation
dsifford
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
mkaz,
nerrad,
ntwb,
talldan and
youknowriad
as code owners
There was a problem hiding this comment.
I did a quick check of npm run lint-js result on Travis: https://travis-ci.com/WordPress/gutenberg/jobs/223779531
It looks a bit better warning wise. It seems like we can fix everything else by adding type definitions or replacing types which don't exist with some alternatives.
| @@ -1,4 +1,7 @@ | |||
| module.exports = { | |||
| extends: [ | |||
There was a problem hiding this comment.
Cool, thanks for making closer to what we had before 💯
gziolo
added
[Package] ESLint plugin
| * | ||
| * @see http://www.typescriptlang.org/docs/handbook/utility-types.html | ||
| */ | ||
| const typescriptUtilityTypes = [ |
There was a problem hiding this comment.
Ideally, this comes from the official TypeScript npm package but I guess it wouldn't be as easy to extract. I did a quick google search and I didn't find anything that would fit.
There was a problem hiding this comment.
Yeah, unfortunately they aren't able to be extracted in this way because they're defined as types and/or interfaces. It would be much cleaner though if that was possible, I agree.
…6975) * fix(eslint-plugin): misc assorted fixes to jsdoc config * fix: misc jsdoc fixes * remove duplicate Readonly
…6975) * fix(eslint-plugin): misc assorted fixes to jsdoc config * fix: misc jsdoc fixes * remove duplicate Readonly
Description
This PR does the following:
voidtype since it appears that's defined inglobalsand we're filtering it out.How has this been tested?
Lints still run and pass. However, there are quite a bit more warnings that are currently showing up. I don't think these warnings are a big deal for now. They'll get handled when I get around to fixing up that package. The warnings are all valid.
Types of changes
Code quality / Bugfix
Checklist: