Fix: Gallery placeholder icon does not appear #17374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
ajitbohra,
Soean and
talldan
as code owners
senadir
approved these changes
Sep 8, 2019
senadir
added
[Block] Gallery
jorgefilipecosta
deleted the
fix/gallery-placeholder-icon-not-appears-build-waring
branch
jorgefilipecosta
changed the title
|
Whoops. Sorry about that. Thanks for the fix, @jorgefilipecosta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #17316 we added new icons to the icon file and removed the fault export but we did not update the import on the edit file and it still wrongly imported the default export.
This PR fixes the import on the gallery edit file.
How has this been tested?
I verified that the gallery icon appears on the media placeholder.