-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Use the latest version of webpack for build and start commands #17746
Conversation
Failed JavaScript unit tests just look like you should update some snaps? |
I will fix it soon. It looks like |
…by webpack changed
Updated with 29a3e3e. Travis seems to be much happier now 🎉 |
@youknowriad - this is another one to include in the npm release process since we use a super out of date version of |
That hash includes also the webpack runtime code. If something in the code that loads and executes the webpack chunks and modules changes, the bundle's hash will change, too. Here's one example of a simple change in the runtime code that happened between 4.8.3 and 4.41.0. It changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI build obviously succeeds and I appreciate the version range change. 👍
Does version range change need a major Semver update?
|
@youknowriad - another one to include in the next npm release. |
…ds (#17746) * Scripts: Use the latest version of webpack for build and start commands * Add changelog entry for webpack upgrade in `@wordpress/scripts` * Update failing tests by regenerating snapshots where hashes produces by webpack changed
Description
This PR upgrades the version of
webpack
used in@wordpress/scripts
.There should be no changes in how
npm run dev
andnpm run build
work in Gutenberg.In addition, I updated the list of dependencies for
@wordpress/scripts
to use ranges for consistency.