Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add captions to gallery block #1831

Closed
wants to merge 2 commits into from
Closed

Add captions to gallery block #1831

wants to merge 2 commits into from

Conversation

mtias
Copy link
Member

@mtias mtias commented Jul 10, 2017

image

Closes #1443.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress labels Jul 10, 2017
@mtias mtias requested review from mkaz and youknowriad July 10, 2017 11:11
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 17.815% when pulling 71d8e19 on add/gallery-captions into 4e0ea5c on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 17.815% when pulling 71d8e19 on add/gallery-captions into 4e0ea5c on master.

left: 0;
right: 0;
figcaption {
position: static;
Copy link
Member

@ellatrix ellatrix Jul 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? I believe MCE will re-add it as inline style.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The positioning is a bit messed up because we'd want to apply it to figcaption on the front end, but to editable in the editor.

@mkaz
Copy link
Member

mkaz commented Jul 20, 2017

I can use some clarification for user experience, the core Media Modal which is used for selecting the image also includes ordering images, and editing captions as part of the standard create gallery flow. This is improved on create with PR #1820

Do we want those interactions to happen within Gutenberg block also, or alternatively could remove from modals (might require core-media work), or just manage within the modals?

cc: @jasmussen and since he's on holiday, @melchoyce

@jasmussen
Copy link
Contributor

I can use some clarification for user experience, the core Media Modal which is used for selecting the image also includes ordering images, and editing captions as part of the standard create gallery flow. This is improved on create with PR #1820

Do we want those interactions to happen within Gutenberg block also, or alternatively could remove from modals (might require core-media work), or just manage within the modals?

In general, the more interactions that can happen on the block itself (without adding undue complexity), the better. The idea is that you should be able to get fully going with a block, with using only the block interface itself. Any advanced configuration can happen in the sidebar/inspector. See also https://github.com/WordPress/gutenberg/blob/master/docs/design.md#block-interface--sidebar--inspector

In the case of the gallery, I see the media modal eventually going away entirely. That is, everything we want to port from the media modal, we should, including sort order. But this doesn't have to happen immediately, and the idea is to move towards "the block" being the only interface you ever have to learn.

/**
* WordPress dependencies
*/
import { __ } from 'i18n';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note with #2172, these need to be updated to prefix the dependencies with @wordpress/. You will need to perform a rebase against the latest version of master and apply your changes:

git fetch origin
git rebase origin/master

@youknowriad
Copy link
Contributor

Looks like this has been superseded by #4199

@gziolo gziolo deleted the add/gallery-captions branch May 7, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants