Remove parent block title from block hover title. #18795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
requested review from
ellatrix,
talldan and
youknowriad
as code owners
|
Very valid thinking here! Like a simplified focus/selected state as pointed out in 18667
And even a way to navigate between parent and child as showed in 17267.
|
|
E2E test failure appears to be unrelated. I'm currently unable to run the E2E tests locally, so I've rebased the branch and repushed the changes to see if the test failure was intermittent. If not, I think I'll need some help figuring out what the issue is. |
|
There was an E2E test failure again, but it wasn't the same test as last time, so I'm assuming the failures must be unrelated to the PR. |
youknowriad
approved these changes
Nov 28, 2019
|
Yep! Nice work! |
ZebulanStanphill
added
[Feature] Blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the editor now has a status bar containing block breadcrumbs, I think the block hover breadcrumb can be simplified to only show the title of the block being hovered. I think this makes the UI a bit clearer; I often found myself getting momentarily confused by the hover title, as the first word you see is not the title of the block you're hovering, but the immediate parent. Since the status bar provides a full breadcrumb of the selected block, I think the hover title should be simplified to only show the title of the hovered block.
How has this been tested?
I checked to make sure the breadcrumb was functional and looked right in both the navigation and standard (what is it called again?) modes.
I am unable to test the mobile version of the UI, but I have not modified the mobile version, and as far as I can tell, none of the changes in this PR should affect the mobile UI.
Screenshots
Checklist: