Keyboard shortcut to toggle block level HTML editing #9723 #19152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmahendrakar
requested review from
ellatrix,
talldan and
youknowriad
as code owners
|
Working atop @MarkDavidTurner's stale pr #11941. Thank you @MarkDavidTurner!
|
gziolo
added
[Type] Enhancement
|
I found one issue when manually testing the feature. It breaks for case of group of blocks - when I try to edit the html, save and toggle off block mode I get block-invalid-warning - The 'After conversion' section on right has un-intented changes ( |
`@import "./colors";` from within `_variables.scss`, since the latter [depends](https://github.com/WordPress/gutenberg/blob/3687e8b992b6462044eead19944cf0c6ea41a1e3/packages/base-styles/_variables.scss#L36-L40) on `$dark-gray-900` which is [defined](https://github.com/WordPress/gutenberg/blob/bfd1117846c7802d62dbba046c27968d961781e7/packages/base-styles/_colors.scss#L7) in the former.
The select tool doesn't let you select text. It's only until you click twice on the same block, press Enter, or select the Edit tool, that you edit text again. Therefore the text-beam cursor is inaccurate. This PR changes that cursor to the default arrow cursor.
* Image Block: Revert circle mask, add "rounded" Fixes #16130, notably a followup to the issue outlined in #16130 (comment). The "circle mask" variation has the benefit of creating a perfect circle out of any shape image. However it doesn't change the dimensions of the image, so the tradeoff is that the image footprint is still large, and resize handles now float in air. This PR changes it to a "rounded" style, which sets a very high border radius ensuring that the smallest sides on a rectangular image are perfectly rounded, creating a pill-shape. When the image is perfectly square, the variation will be perfectly circular. This ensures that the variation is useful both when images are rectangular, it ensures the resize handles are appropriately placed, it fixes an issue where Microsoft Edge did not render the mask properly, and it indicates to the user that if they want a perfect circle, they can upload a square image, or change the dimensions in the sidebar. * Add back-compat.
…#19037) This avoids showing the option when it won't do anything.
* Add end 2 end tests InnerBlocks renderAppender * Fixed intermittent problem. * Address reviews
Adds an image size selector to the gallery block that allows users to choose the size of the images. It defaults to the large size.
* Expanding on sentance case to everywhere else So far we have only done this in the tooltips and in menus. If sentance case of right approach we should consider taking this across all areas. Included in this: - Side panel - Block library - Settings There may be areas missed, but gives a starting view to see if everyone agrees to go forward with this across everything. If we do, then we need a patch for core. Expands on #16764 * Catch a few missed * Update tag * Test catches Fixes test issues. * Catches the test fails for sentance case. * Test fix * Update index.js * Catch some more test fails * Test fixes * Override WP labels for post and page types … to conform to sentence-style capitalisation across the editor UI. (This is a quick commit to show the idea. Do expand on it and polish.) From Slack: "If we used this it would have to be properly marked [e.g. @todo] and commented so that before the next core release we could revisit these labels as a whole." * gutenberg_override_posttype_labels: small fixes
* Edit Site: Bootstrap package. * Edit Site: Link package. * Edit Site: Load assets in new Edit Site Page. * Edit Site: Render basic editor.
* Add tests for adding navigation blocks using two different methods * Avoid showing placeholder until pages are loaded * Fixes for tests * Revert "Avoid showing placeholder until pages are loaded" This reverts commit 0dd1a36. * Fix various issues with tests * Handle console warning * Use a mocked response from the pages endpoint * Also mock the search response * Try fixing e2e tests when run on travis CI. * Update button label
* Add an additional warning for the FSE experiment setting * Updated warning text * Update the copy some more
…#19122) * Block Editor: Get categories from the store directly in the inserter * Block Editor: Extract searchItems into its own file * Improve the way terms are matched in the block inserter
added 7 commits
December 25, 2019 16:15
dmahendrakar
requested review from
adamsilverstein,
aduth,
ajitbohra,
atimmer,
chrisvanpatten,
daniloercoli,
etoledom,
gziolo,
jorgefilipecosta,
karmatosed,
mapk,
mkaz,
mmtr,
nerrad,
noisysocks,
oandregal,
ntwb,
SergioEstevao,
Soean and
TimothyBJacobs
as code owners
|
Opened another pr for the same: #19329 |
dmahendrakar
deleted the
add/keyboard-shortcut-for-block-level-HTML-editing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds keyboard short cut for block level HTML editing - Fixes #9723
How has this been tested?
Added snapshot test.
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: