Edit Post: Increase top toolbar breakpoint to avoid overflows in the header. #19442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiqueras
added
[Type] Bug
jorgefilipecosta
approved these changes
Jan 6, 2020
youknowriad
reviewed
Jan 7, 2020
| @@ -54,7 +54,7 @@ | |||
| } | |||
|
|
|||
| // Move toolbar into top Editor Bar. | |||
| @include break-xlarge { | |||
| @include break-wide { | |||
There was a problem hiding this comment.
I feel like we keep increasing this breakpoint so it feels like no matter the value used, there will be overflow at some point. I wonder if there's another way to fix this. Maybe a menu that wraps when it hits the limit.
There was a problem hiding this comment.
The toolbar should collapse into a menu, yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The top toolbar's breakpoint for going from a second line in the header to a single one was too small, and content overflowed. This PR increases it.
How has this been tested?
The header no longer overflows around 1100 pixels viewport width.
Screenshots
Types of Changes
Bug Fix: The header's top toolbar no longer overflows content on some screen sizes.
Checklist: