Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useColors: fix contrast check #19500

Merged
merged 1 commit into from
Jan 8, 2020
Merged

useColors: fix contrast check #19500

merged 1 commit into from
Jan 8, 2020

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Jan 8, 2020

Description

Introduced in #19046.
Props to @epiqueras for finding the problem in #19474 (comment).

Instead of checking the node type, the node itself is checked.

How has this been tested?

Create a paragraph and make the text colour white (with a light inherited background). Type something in the block to trigger a change (it's strange that this is necessary). The contrast warning should be displayed.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@ellatrix ellatrix added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Jan 8, 2020
@ellatrix ellatrix merged commit 87e5415 into master Jan 8, 2020
@ellatrix ellatrix deleted the fix/color-contrast-check branch January 8, 2020 09:31
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant