Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a new order and grouping for the toolbar controlsTry/toolbar controls order grouping #1963

Closed
wants to merge 5 commits into from

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Jul 20, 2017

This PR is a first try to experiment the design proposal in #467. Before moving on and refine things, it would be great to have some testing and feedback.

Gains:

  • Publishing is the main goal here, so that should be the first action.
  • Previewing is related to achieving that goal, and to preview you need to save, so grouping those actions together will eliminate some confusion. The icon for saving can also display a spinner (and then a checkmark) while (auto)saving.
  • In order of 'user needs', adding blocks to the page is next up, followed by undo-ing and re-do-ing what you do in those blocks. This also groups the icon + text buttons, which brings some calm to the toolbar.
  • Switching from visual to text is something you do a limited amount of times per post edit, so it should be clearly findable, but not a blocking higher-order element.
  • The settings toggle should be directly next to the sidebar, as it will 'spawn' something coming from that side of the screen. Making it stick to that side will make it more intuitive if somebody is searching for it. When the sidebar is hidden, the mode switcher could move next to the settings button.

Screenshot on the issue.

Note: the save buttons would need a new icon.

Minor glitches to address noticed so far:

  • when saving, the Save button text changes and thus the button width changes: all the following elements get moved horizontally
  • when closing the sidebar, the "Mode Switcher" hangs in a awkward position :)

The responsive view has some pre-existing issues, unrelated to this PR. However, now also the Preview link gets hidden on very small screens, this improves things a bit.

Personally, I think this goes in the right direction even if maybe it's not still there. Grouping together Publish, Saved state, and Preview makes a lot of sense to me.
Considering plugins might want to add their controls in the toolbar, the space is very limited especially on small screens. Maybe worth considering to split the Inserter, Undo/Redo and move them elsewhere...

@afercia
Copy link
Contributor Author

afercia commented Jul 20, 2017

screen shot 2017-07-20 at 17 14 15

@anna-harrison
Copy link

Hi - I've spent some time looking through the design issues in this ticket, as well as the related discussion in #467, and have penned recommendations and backing research here

tl;dr we will need to make a choice as to whether we optimise the design for sighted readers, or for screen readers as eye-tracking research indicates that these two use cases are at odds with each other

Taking all the factors into consideration, I would recommend that the toolbar is implemented as follows, full rationale in the notes here

image 5

/cc @melchoyce @karmatosed @jasmussen @afercia

@karmatosed
Copy link
Member

karmatosed commented Aug 25, 2017

Thanks for taking time to look at this @annaephox

we will need to make a choice as to whether we optimise the design for sighted readers, or for screen readers as eye-tracking research indicates that these two use cases are at odds with each other

I think we need to be very careful here as both are important users. I still believe we can make it work for both. It's worth noting eye-tracking isn't a perfect research to rely on. We totally can consider it as part of the research but it's not good to use it as a rule. Where things like neurodiversity and vision complications come in, it simply can't be relied - that is a lot of the population.

With regards to the PR, there's a lot here so lets break down into sections. First, I do not think reversing the order makes sense. The top right is prime location (although we could debate is that only in cultures where the language flows that direction) and having that be the publish feels and works naturally for users. @afercia is there no way that can be accessible?

@karmatosed
Copy link
Member

Closing as I advised this to be broken down and we need to get feedback from testing.

@karmatosed karmatosed closed this Dec 14, 2017
@gziolo gziolo deleted the try/toolbar-controls-order-grouping branch May 7, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants