Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Nav Block to use new showInitialSuggestions prop on LinkControl #19667

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Update Nav Block to use new showInitialSuggestions prop on LinkControl #19667

merged 1 commit into from
Jan 15, 2020

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jan 15, 2020 •
edited
Loading

Description

Fixes #19458 by ensuring that Nav Block uses the new showInitialSuggestions prop.

How has this been tested?

See #19458

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@getdave getdave self-assigned this Jan 15, 2020
@getdave getdave added the [Block] Navigation Affects the Navigation Block label Jan 15, 2020
@getdave getdave mentioned this pull request Jan 15, 2020
Merged
6 tasks
retrofox
retrofox approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@getdave getdave merged commit a14b498 into master Jan 15, 2020
@getdave getdave deleted the fix/nav-block-use-correct-prop-for-initial-suggestions branch January 15, 2020 13:59
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retrofox retrofox retrofox approved these changes

@jeryj jeryj Awaiting requested review from jeryj

@frontdevde frontdevde Awaiting requested review from frontdevde

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees

@getdave getdave

Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Milestone
Gutenberg 7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@getdave @retrofox @ellatrix