Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use noop for focus command on format edit. #19668

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Use noop for focus command on format edit. #19668

merged 1 commit into from
Jan 15, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jan 15, 2020 •
edited
Loading

Description

Update the native version of RichText to support these changes here: #19536

How has this been tested?

This can be tested in this GB-mobile PR: wordpress-mobile/gutenberg-mobile#1778

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@SergioEstevao SergioEstevao added the [Type] Bug An existing feature does not function as intended label Jan 15, 2020
@SergioEstevao SergioEstevao added this to the Future milestone Jan 15, 2020
geriux
geriux approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on both iOS and Android main apps and the demo app. Thanks for the fix!

@SergioEstevao SergioEstevao merged commit b5c9419 into master Jan 15, 2020
@SergioEstevao SergioEstevao deleted the rnmobile/fix_onfocus branch January 15, 2020 14:08
@ellatrix ellatrix modified the milestones: Future, Gutenberg 7.3 Jan 20, 2020
@SergioEstevao SergioEstevao mentioned this pull request Jan 22, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioEstevao @geriux @ellatrix