Don't show protocol on suggestions in navigation

[sainthkh]

Closes #19670

Description

On suggestions of navigation, protocols won't be shown.

How has this been tested?

• I added test case in LinkControl test.
• Test Env: Ubuntu 18.04 Node 12.14.1
• It's a simple change in LinkControl. It doesn't affect others.

Screenshots

Before:

After:

Types of changes

Simple fix. (I don't think it's either a bug or a new feature) It doesn't break anything.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• [N/A] My code follows the accessibility standards.
• My code has proper inline documentation.
• [N/A] I've included developer documentation if appropriate.
• [N/A] I've updated all React Native files affected by any refactorings/renamings in this PR.

[earnjam]

filterURLForDisplay() also strips off www in addition to protocols. I'm not sure that's what we want here.

[aduth]

It might not be what was prescribed by #19670, but if how we're presenting the link here aligns to the purpose of how a function like filterURLForDisplay is expected to be used, then we should embrace the consistency that comes with it. We might decide that trimming www. is not something we want to do for URLs filtered for display, but it's a change which should happen in the implementation of filterURLForDisplay, and not a decision we should want to make at any particular instance of where that function is used.

Or, if it is a decision that depends on the context of where the URL is presented, then we can incorporate that as an option of the function. I'm inclined to think we should try to avoid that if possible, for the sake of consistency (URLs appearing same everywhere), simplicity (smaller function signature), and maintainability (needing to make decisions is a hurdle we can often avoid).

[earnjam]

There didn't seem to be a consensus in #19670 about whether this was the right thing to do. For the recent posts from the current site, we may not need to show a domain at all since it's implied and should be known. But for direct entry URLs, we probably should keep the full thing, including protocols.

[aduth]

There didn't seem to be a consensus in #19670 about whether this was the right thing to do.

I'm personally a bit conflicted:

• On one hand, I feel it makes it appear less obvious as a URL. To me, if we want to have a URL in this preview, then it should appear as a URL.
• On the other hand, we have this function filterURLForDisplay which presumably exists to control how we want URLs to look in a UI context. On that basis alone, processing it through the function makes sense. And it could even allow us to change how we display URLs by simply adjusting the implementation of filterURLForDisplay.

It probably should have been added to #19670, but I'll add the "Needs Design Feedback" since I think it would help to solicit additional design feedback / perspective here.

[karmatosed]

I think visually I prefer it as it is obvious it's URL. Let's get this in and code reviewed. I think because of where it is and format, it's obviously a URL.

[aduth]

The branch is quite old, so I've rebased it to ensure everything's still in order against the latest master. Otherwise, the code looks solid 👍