-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: cover text block with color options #2036
Conversation
mtias
commented
Jul 26, 2017
7f81816
to
b7b9e8b
Compare
I love this feature. I love it so much that I think this shouldn't be a separate block, but indeed the text block. This would require there was a "no swatch" option, though, to remove a color if you've already set one. We'd probably also want to add the block padding only if a swatch is selected, and longer term we'd want themes to be able to provide the swatches. However, I can understand that it would also be good to get some testing for this feature before deciding that the text block needs it. Especially when we're this close to 1.0. We might also find that this isn't a text feature at all, but instead the first block that is intended for other blocks to be nested inside. (Matías idea in a chat discussion) As such, in the name of testing, 👍 👍 for merging from me. |
I just realize that this block breaks a little bit with the design patterns laid forth in https://github.com/WordPress/gutenberg/blob/master/docs/design.md, which suggest that any basic actions you need to be able to take on the block should be doable without having the sidebar open. Since the primary purpose of this block is to change the background color and this is done in the inspector, it's arguably crossing that line. It's not important to fix this right now, because the meta purpose of this block is to "explore what's possible" in Gutenberg, and it does that super well. Later on, though, when we have time to fix, we can do it in a ton of ways, though:
|
I like this block, much. Some options that could be added, so it could be more versatile.
|
Yes! This needs to exist for themes to supply a palette, and could be easily configurable by plugins as well.
I disabled floated left/right from this block, but we can easily enable it back if we think it'd be useful. |
I'd love to eventually see this idea merged with Cover Image to create a... nestable "Banner" or "Section" block, maybe? Wording on it will be hard. I'm thinking:
|