Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Typo improved: Correctness grammar #20386

Merged
merged 3 commits into from
Mar 3, 2020

Conversation

pmbaldha
Copy link
Contributor

The noun phrase forked repository seems to be missing a determiner before it. Consider adding an article.

@Soean Soean added the [Type] Developer Documentation Documentation for developers label Feb 23, 2020
@talldan
Copy link
Contributor

talldan commented Feb 24, 2020

I think there are lots of little improvements that could be made here. What do you think about updating the PR to include more fixes @pmbaldha?

I think it could be updated to the following:

  • Fork the Gutenberg repository.
  • Clone the forked repository.
  • Create a new branch.
  • Make code changes.
  • Commit the code changes within the newly created branch.
  • Push the branch to the forked repository.
  • Submit a Pull Request to the Gutenberg repository.

@pmbaldha
Copy link
Contributor Author

pmbaldha commented Mar 1, 2020

@talldan @Soean I have just made changes as @talldan suggested. Can you please review it? Thank you very much

Co-Authored-By: Marek Hrabe <marekhrabe@me.com>
@pmbaldha
Copy link
Contributor Author

pmbaldha commented Mar 2, 2020

@marekhrabe I have committed your changes.

Copy link
Contributor

@marekhrabe marekhrabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marekhrabe marekhrabe merged commit 742dbf2 into WordPress:master Mar 3, 2020
@github-actions github-actions bot added this to the Gutenberg 7.7 milestone Mar 3, 2020
@paaljoachim
Copy link
Contributor

paaljoachim commented Sep 21, 2020

It would be very helpful to add a Quick Guide. A step by step terminal command approach similar to this:
https://developer.wordpress.org/block-editor/tutorials/devenv/#quickstart

Taking the list @talldan mentioned expanding it with the terminal commands used.

Thank you!

@talldan
Copy link
Contributor

talldan commented Sep 30, 2020

@paaljoachim This PR was just fixing some typos to the existing documentation (the list of steps was already present), so I don't think it's fair to ask this contributor to make the changes you're requesting.

Would you be able to make a separate issue for any improvements?

@paaljoachim
Copy link
Contributor

Hey Dan. I totally agree on your comment.
I am not sure which documentation this is in relation to, so that it why I added the comment here. I can of course add a new issue where I link to the correct place in the doc (I just need the link). Thanks.

@talldan
Copy link
Contributor

talldan commented Sep 30, 2020

@paaljoachim Here's the docs:
https://github.com/WordPress/gutenberg/blob/master/docs/contributors/git-workflow.md

Looks like there already detailed instructions after the summary, so no further changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants