Use the EditorSkeleton component in the edit-site page #20440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
force-pushed
the
update/editor-skeleton-edit-site
branch
from
e802e74 to
2f44d17
Compare
|
Size Change: -525 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
epiqueras
approved these changes
Feb 25, 2020
| role="region" | ||
| aria-label={ __( | ||
| 'Widgets screen content' | ||
| ) } | ||
| tabIndex="-1" |
There was a problem hiding this comment.
I didn't because there's an onFocus handler. So it must be important for block unselection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid duplicating the same CSS over and over, this PR reuses the EditorSkeleton in the edit-site package. It also removes some leftovers from the edit-widgets package.