Remove template locking from the columns block #20465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Size Change: -45 B (0%) Total Size: 865 kB
ℹ️ View Unchanged
|
aduth
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Code-wise, this makes sense to me. I believe one of the original reasons for the locking was due to the lack of a horizontal mover, and the vertical movers not making much sense in this context. Since that the horizontal mover functionality exists, it seems reasonable to me to make this change.
Comment on lines
-12
to
-18
| // Ideally all block toolbars should be positioned the same. | ||
| .components-popover.block-editor-block-list__block-popover | ||
| .components-popover__content | ||
| .block-editor-block-contextual-toolbar[data-type="core/column"] { | ||
| margin-left: 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
What was the purpose of these styles?
There was a problem hiding this comment.
I don't know @jasmussen maybe, It was definitely breaking the column block toolbar position though.
There was a problem hiding this comment.
These styles were almost certainly necessary due to the complex left/right margins that innerblock containers used to be born with.
But it's easy to test, if the toolbar is positioned correctly according to the block selected, then these styles are not needed anymore. And good riddance!
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all the new UI updates, I don't think there's a valid reason to keep the template locking in the Columns block. What this means concretely is that the columns block becomes just a list of "column" block, you can remove/add any columns you want and also use the block movers (horizontal) from the toolbar to move columns.