Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add natural columns pattern #20587

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Add natural columns pattern #20587

merged 1 commit into from
Mar 6, 2020

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Mar 2, 2020 •
edited
Loading

This adds the natural columns patter from #20345
I had to remove a column and replace the images with images from w.org CDN.
It's clear that the choice of images there is lacking (I also don't have any idea how to browse the CDN)

Capture d’écran 2020-03-02 à 3 14 34 PM

@youknowriad youknowriad added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Mar 2, 2020
@youknowriad youknowriad self-assigned this Mar 2, 2020
@github-actions
Copy link

github-actions bot commented Mar 2, 2020

Size Change: 0 B

Total Size: 865 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.01 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 105 kB 0 B
build/block-editor/style-rtl.css 10.5 kB 0 B
build/block-editor/style.css 10.5 kB 0 B
build/block-library/editor-rtl.css 7.4 kB 0 B
build/block-library/editor.css 7.4 kB 0 B
build/block-library/index.js 116 kB 0 B
build/block-library/style-rtl.css 7.5 kB 0 B
build/block-library/style.css 7.5 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.6 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 5.76 kB 0 B
build/core-data/index.js 10.5 kB 0 B
build/data-controls/index.js 1.03 kB 0 B
build/data/index.js 8.22 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 90.9 kB 0 B
build/edit-post/style-rtl.css 8.53 kB 0 B
build/edit-post/style.css 8.53 kB 0 B
build/edit-site/index.js 4.63 kB 0 B
build/edit-site/style-rtl.css 2.51 kB 0 B
build/edit-site/style.css 2.51 kB 0 B
build/edit-widgets/index.js 4.42 kB 0 B
build/edit-widgets/style-rtl.css 2.59 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 325 B 0 B
build/editor/editor-styles.css 327 B 0 B
build/editor/index.js 44.6 kB 0 B
build/editor/style-rtl.css 4.01 kB 0 B
build/editor/style.css 4 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.6 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.48 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.02 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.54 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@MichaelArestad
Copy link
Contributor

@youknowriad This is an awesome start. I believe we need to figure out a more structured path forward with example images. I could provide the images I used in my screenshot, but I'd like to get a more curated group of images to use here. I don't think that's a blocker for this, but if we merge this in, we'll want to stub out an issue to improve the images.

@MichaelArestad MichaelArestad removed the Needs Design Feedback Needs general design feedback. label Mar 5, 2020
@MichaelArestad
Copy link
Contributor

This probably could also use a copy review.

@youknowriad youknowriad merged commit d250e2b into master Mar 6, 2020
@youknowriad youknowriad deleted the add/natural-columns branch March 6, 2020 07:11
@youknowriad
Copy link
Contributor Author

Merged, we can still improve it but I'd love to have a good set of patterns before the next release.

@github-actions github-actions bot added this to the Gutenberg 7.7 milestone Mar 6, 2020
@mapk
Copy link
Contributor

mapk commented Mar 6, 2020

@enriquesanchez is working on a set of themed images that share color values.

@lancewillett
Copy link
Contributor

get a more curated group of images to use here

Just curious about this, as the same challenge happens in other parts of the WordPress ecosystem (and likely other open source projects).

High quality images that are open-licensed — rare, zero? 😄

@youknowriad
Copy link
Contributor Author

@lancewillett There's this ticket where they're discussing adding some images to the WP CDN. https://core.trac.wordpress.org/ticket/49580

I know previously we relied on images that fell into the public domain.

@enriquesanchez
Copy link
Contributor

Hey @lancewillett! 👋

You're right, we have found it very hard to find a decent set of high-quality public domain images. What we've been doing so far is using images volunteered by members of the community.

@ellatrix ellatrix mentioned this pull request Jun 16, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtias mtias Awaiting requested review from mtias

@mapk mapk Awaiting requested review from mapk

@MichaelArestad MichaelArestad Awaiting requested review from MichaelArestad

@enriquesanchez enriquesanchez Awaiting requested review from enriquesanchez

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees

@youknowriad youknowriad

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 7.7
Development

Successfully merging this pull request may close these issues.
5 participants
@youknowriad @MichaelArestad @mapk @lancewillett @enriquesanchez