Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(env): ports must be integers #20662

Merged
merged 1 commit into from
Mar 5, 2020
Merged

docs(env): ports must be integers #20662

merged 1 commit into from
Mar 5, 2020

Conversation

simono
Copy link
Contributor

@simono simono commented Mar 5, 2020

port and testsPort need to be integers, see https://github.com/WordPress/gutenberg/blob/master/packages/env/lib/config.js#L164

Description

Update docs to match code.

How has this been tested?

Documentation is now correct.

Types of changes

Doc updates.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats right, thanks for the pull request.

@Soean Soean added [Tool] Env /packages/env [Type] Developer Documentation Documentation for developers labels Mar 5, 2020
@Soean Soean merged commit 7e3c785 into WordPress:master Mar 5, 2020
@github-actions github-actions bot added this to the Gutenberg 7.7 milestone Mar 5, 2020
@simono simono deleted the patch-2 branch March 29, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tool] Env /packages/env [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants