Check for match in stylesheet host and protocol #20673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
the
[Type] Bug
|
Size Change: +319 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
talldan
approved these changes
Mar 6, 2020
| styleSheet.href.includes( window.location.hostname ) | ||
| matcheableUrl && | ||
| matcheableUrl.length > 2 && | ||
| matcheableUrl[ 1 ] === window.location.protocol && |
There was a problem hiding this comment.
The url package has a getProtocol function that might be useful as this could be simplified to getProtocol( styleSheet.href ) === window.location.protocol.
There was a problem hiding this comment.
Oooh great tip, thanks! Updated.
| matcheableUrl && | ||
| matcheableUrl.length > 2 && | ||
| matcheableUrl[ 1 ] === window.location.protocol && | ||
| matcheableUrl[ 2 ] === window.location.host |
There was a problem hiding this comment.
The url package also has getAuthority function, which seems like it returns the same url part as the window.location.host (subdomain.domain:port).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #20632.
How has this been tested?
Tested in several browsers (including IE) and ran automated tests.
Screenshots
Types of changes
Checklist: