-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update storyshot snapshots to fix failing tests #21147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 860 kB ℹ️ View Unchanged
|
aduth
approved these changes
Mar 25, 2020
Two notes:
|
Previously: #20514 |
@aduth yes sorry, I should have thought to rebase that before merging, I will definitely do that in the future. I keep getting failing e2e tests on the PR so I am unable to merge, anything you can do? Failing tests preventing a fix for other failing tests 🤦♂ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The javascript unit-tests are failing in Travis on master because some of the auto-generated id's in the storyshot integration are out of date, this updates that.
How has this been tested?
run
npm run test-unit -- --testPathPattern storybook
Types of changes
Bug fix (non-breaking change which fixes an issue)