Move caret to the end of pasted content #21755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Bug
adamziel
requested review from
ajitbohra,
chrisvanpatten,
etoledom,
jorgefilipecosta,
mkaz,
SergioEstevao and
youknowriad
as code owners
|
Size Change: +64 B (0%) Total Size: 816 kB
ℹ️ View Unchanged
|
|
This fix is so anticipated, thanks for working on it 👍 There are two unit tests to fix, see https://travis-ci.com/github/WordPress/gutenberg/jobs/321645821 for more details. It would be a great follow-up task to add e2e test that covers this fix as another PR. |
adamziel
force-pushed
the
fix/caret-position-after-paste
branch
from
7884c55
to
2e51bda
Compare
|
@gziolo All checks are green now. Agreed about the e2e tests - will look into it once this one lands. |
|
Could an e2e test be added as part of this PR, please? Otherwise it will be easy for this to regress with selection and rich text refactorings. |
ellatrix
reviewed
Apr 23, 2020
| typeof action.initialPosition === 'number' | ||
| ) { | ||
| return action.initialPosition; | ||
| } else if ( action.type === 'SELECT_BLOCK' ) { |
There was a problem hiding this comment.
Why is the type check needed above, but not here?
There was a problem hiding this comment.
This PR adds a numeric initialPosition to the REPLACE_BLOCKS action in some circumstances only which means it may or may not be present. It doesn't do anything to SELECT_BLOCK action so I left that code branch untouched - I assume there's always initialPosition available.
There was a problem hiding this comment.
Aside: you could consolidate those two if statements into one that uses ||.
There was a problem hiding this comment.
If you insist I will, but I think it's more readable like that with a dedicated branch for each action :-)
There was a problem hiding this comment.
I respect your preference, if ESLint doesn’t complain it’s fine as is 😃
gziolo
reviewed
Apr 24, 2020
packages/e2e-tests/specs/editor/various/multi-block-selection.test.js
Outdated
Show resolved
Hide resolved
gziolo
approved these changes
Apr 28, 2020
adamziel
force-pushed
the
fix/caret-position-after-paste
branch
from
fd322c7
to
5240e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you paste a couple paragraphs into Gutenberg, your cursor remains at the beginning of the last paragraph you pasted. I expect it to be at the end of the last paragraph pasted. This PR updates initialPosition to -1 which, in turn, moves the caret to the end of the paragraph.
Solves #5317
How has this been tested?
Tested locally:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: