Remove negative margin on help text

[johnstonphilip]

Description

When using the TextAreaControl component, the help text is overlapping the box due to a negative margin being applied, and the parent not having margin only because it is within a tabPanel.

This PR removes that inconsistency and now the help text sits properly.

How has this been tested?

Visual testing.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[youknowriad]

since this is a global style applied to all controls, I want to ask whether there's potential impact on other Controls?

[johnstonphilip]

@youknowriad I have gone through all of the settings I can think of and I am not seeing any impact or regressions. Thoughts @jasmussen?

[jasmussen]

Hi, thanks for the ping. And thanks for the PR — that overlapping help text is frustrating, let's get that fixed.

From a glance at the code, it looks like the rule was initially added to polish the font size picker. But this one appears unchanged with this applied, probably because it changed so much since then, it used to be a slider. Before:

After:

However there are some things that changed, and actually regressed, with this. Here are two I found:

Visibility, before:

Visibility, after:

Comments, before:

Comments, after:

As you can see, the margins aren't that great here.

I did not have time to do extensive testing of all blocks and various plugins, but as Riad said, it's a widely used component so it's likely there will be other places where this is weird.

It seems like the ideal solution is to test widely, and provide fixes for as many cases as we can.

The other would be to find a different way to fix the textarea+helptext issue.

[johnstonphilip]

@jasmussen Thanks! I didn't notice those at first, but I know I don't have the eagle eyes that you do for these things :)

I will see if I can work up another way and add that to this PR.

[annezazu]

I'm going to close this out both due to inactivity and due to how much has changed in these interfaces! I welcome you to reopen the PR/rework it if you want to continue the work done here (and if the issue still applies). Happy to reopen if you don't have access -- just say the word :)