Block API: Block Context: Assign block global for render_callback #21868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Feature] Block API
aduth
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
mkaz,
nerrad,
ntwb,
Soean,
talldan,
TimothyBJacobs and
youknowriad
as code owners
|
Size Change: 0 B Total Size: 835 kB ℹ️ View Unchanged
|
aduth
force-pushed
the
update/block-context-global
branch
from
8ec1fdb
to
638bfcb
Compare
1 task
aduth
force-pushed
the
update/block-context-global
branch
from
638bfcb
to
30e4399
Compare
3 tasks
marecar3
pushed a commit
that referenced
this pull request
Apr 27, 2020
…1868) * Framework: WP_Block: Assign block global for render_callback * Block API: Mark block global as experimental
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #21467
Temporary resolution for: #21797
This pull request seeks to revert changes to the PHP
render_callbacksignature introduced in #21467. In order to provide block context, it now assigns a$blockglobal with the current block instance immediately before a block type'srender_callbackis invoked. This restores an initial implementation of #21467, where there are some justifications for use of a global in the original comment (strikethroughtext) and #21467 (comment).Testing Instructions:
Repeat testing instructions from #21467. Optionally, it was made easier to test in later development of #21467, using the "Gutenberg Test Block Context" plugin included in the default development environment, via the associated "Test Context Provider" block.
There are also a number of automated tests to verify:
(If you have trouble getting PHP unit tests running, try referring to guidance at #21467 (comment))