-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Coding Guidelines: Document JavaScript language support commitment #22030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
requested review from
ajitbohra,
chrisvanpatten,
nerrad,
ntwb and
youknowriad
as code owners
May 1, 2020 14:57
Size Change: -3.24 kB (0%) Total Size: 822 kB
ℹ️ View Unchanged
|
gziolo
reviewed
May 1, 2020
gziolo
approved these changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we can land this proposal in the current shape and disabled the shippedProposals
flag in the WP Babel preset separately.
gziolo
reviewed
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21978
This pull request seeks to document the project's support commitment for new JavaScript language features. Currently, there is an informal commitment that Gutenberg will only support TC39 Stage 4 ("Finished") ECMAScript (JavaScript) language features. This commitment manifests itself in default configurations, notably
@wordpress/babel-preset-default
. With these changes, this commitment is formalized via written documentation.I've included documentation in both the Coding Guidelines and in the README of
@wordpress/babel-preset-default
. I've also included guidance in the documentation of@wordpress/babel-preset-default
for how to override the default preset behavior.Testing Instructions:
As the only changes affect documentation, it is not expected there should be any impact on the runtime behavior of the application.