Add Block Pattern Categories support #22164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Feature
|
Size Change: +591 B (0%) Total Size: 833 kB
ℹ️ View Unchanged
|
youknowriad
commented
May 7, 2020
packages/block-editor/src/components/inserter/block-patterns.js
Outdated
Show resolved
Hide resolved
mtias
reviewed
May 7, 2020
mtias
reviewed
May 7, 2020
mtias
reviewed
May 7, 2020
mtias
reviewed
May 7, 2020
packages/block-editor/src/components/inserter/block-patterns.js
Outdated
Show resolved
Hide resolved
mcsf
reviewed
May 7, 2020
|
Should we have an "All" category that also serves as a catch if a category is not registered? |
Added 👍 good call |
mcsf
reviewed
May 7, 2020
packages/block-editor/src/components/inserter/block-patterns.js
Outdated
Show resolved
Hide resolved
Comment on lines
+130
to
+129
| if ( ! pattern.categories || ! pattern.categories.length ) { | ||
| return Infinity; |
There was a problem hiding this comment.
This can be moved above the indexedCategories assignment.
packages/block-editor/src/components/inserter/block-patterns.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/inserter/block-patterns.js
Outdated
Show resolved
Hide resolved
gziolo
reviewed
May 8, 2020
| __experimentalBlockPatternCategories, | ||
| } = select( 'core/block-editor' ).getSettings(); | ||
| return { | ||
| patterns: __experimentalBlockPatterns, |
There was a problem hiding this comment.
For consistency it would be better to use patterns and patternCategories or both of them prefixed with block. I guess the shorter one is enough in this context.
youknowriad
requested review from
ajitbohra,
chrisvanpatten and
mkaz
as code owners
youknowriad
force-pushed
the
add/pattern-categories
branch
from
878c879
to
ac3ae5b
Compare
|
Anyone for a ✅ here |
mtias
approved these changes
May 15, 2020
swissspidy
reviewed
May 15, 2020
| * Register default pattern categories if not registered in Core already. | ||
| */ | ||
| if ( class_exists( 'WP_Block_Pattern_Categories_Registry' ) ) { | ||
| register_block_pattern_category( 'text', array( 'label' => __( 'Text', 'gutenberg' ) ) ); |
There was a problem hiding this comment.
Maybe _x() would be useful to set context?
swissspidy
reviewed
May 15, 2020
| */ | ||
| if ( class_exists( 'WP_Block_Pattern_Categories_Registry' ) ) { | ||
| register_block_pattern_category( 'text', array( 'label' => __( 'Text', 'gutenberg' ) ) ); | ||
| register_block_pattern_category( 'hero', array( 'label' => __( 'Hero', 'gutenberg' ) ) ); |
There was a problem hiding this comment.
_x() would be especially useful for this case IMO. Could be very confusing for translators.
aduth
reviewed
May 15, 2020
| /> | ||
| ) : ( | ||
| <BlockPatternPlaceholder key={ pattern.name } /> | ||
| const indexedCategories = Object.fromEntries( |
There was a problem hiding this comment.
Object.fromEntries is newer than the wp-polyfill polyfill provides. It's not polyfilled for Internet Explorer.
TypeError: Object doesn't support property or method 'fromEntries'
at Anonymous function (http://192.168.1.162:8888/wp-content/plugins/gutenberg/build/block-editor/index.js?ver=cfa28e6fe47f5d29787baf4893617371:20456:5)
at Anonymous function (http://192.168.1.162:8888/wp-content/plugins/gutenberg/build/block-editor/index.js?ver=cfa28e6fe47f5d29787baf4893617371:20467:7)
at Anonymous function (http://192.168.1.162:8888/wp-content/plugins/gutenberg/build/block-editor/index.js?ver=cfa28e6fe47f5d29787baf4893617371:20466:5)
at mountMemo (http://192.168.1.162:8888/wp-includes/js/dist/vendor/react-dom.js?ver=16.9.0:15807:3)
at HooksDispatcherOnMountInDEV.useMemo (http://192.168.1.162:8888/wp-includes/js/dist/vendor/react-dom.js?ver=16.9.0:16029:9)
at useMemo (http://192.168.1.162:8888/wp-includes/js/dist/vendor/react.js?ver=16.9.0:1680:3)
at BlockPatternsPerCategories (http://192.168.1.162:8888/wp-content/plugins/gutenberg/build/block-editor/index.js?ver=cfa28e6fe47f5d29787baf4893617371:20465:3)
at renderWithHooks (http://192.168.1.162:8888/wp-includes/js/dist/vendor/react-dom.js?ver=16.9.0:15246:3)
at mountIndeterminateComponent (http://192.168.1.162:8888/wp-includes/js/dist/vendor/react-dom.js?ver=16.9.0:17480:5)
at beginWork$1 (http://192.168.1.162:8888/wp-includes/js/dist/vendor/react-dom.js?ver=16.9.0:18624:9)
There was a problem hiding this comment.
Oh, TIL. fromEntries was my suggestion, and I didn't stop to think it was a recent addition.
There was a problem hiding this comment.
@youknowriad, we can replace this directly with lodash.fromPairs.
There was a problem hiding this comment.
yes, that's what I did in #22410
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #22141
closes #20816
Adds support for Block Pattern Categories:
Todo
Testing instructions