Scripts: Support split Jest configuration for test commands #22477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Enhancement
7 tasks
|
Size Change: +12.6 kB (1%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #12437 (comment)
This pull request seeks to enhance
wp-scriptsto support disambiguation of configurations by test command. Currently, if a project has ajest.config.jsorjestconfiguration, it will take effect for bothtest-e2eandtest-unitcommands. There is no way to force one or the other to use the default, and there's no easy way to provide a custom configuration for one or the other environment specifically (except via explicit--configflag).With these changes, a developer can now have a
jest-unit.config.jsorjest-e2e.config.js(or.json) files to target configurations as applying to the specific applicable test command.The prioritization is a bit complex, but the idea is:
--config(-c) if provided.jest-unit.config.js,jest-e2e.config.js), use it.jest.config.jsor thepackage.jsonjestdirective is present, use it.Testing Instructions:
It's not especially easy to test except by having an environment which uses
wp-scripts, then usingnpm linkin thepackages/scriptdirectory of this branch. I've tested it in local changes of the Dones project where I originally encountered issues. I confirmed thatjest-e2e.config.jsis recognized, and also that omitting an e2e-specific configuration and providing onlyjest-unit.config.jsallows the default end-to-end configuration to be used.(In Progress: Not yet implemented, but I suppose it would be good to include some unit tests for the new
getJestOverrideConfigFileutility)