Remove Gutenberg form control resets and include the styles in the components #22596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
jorgefilipecosta,
Soean and
talldan
as code owners
youknowriad
added
[Feature] UI Components
|
Size Change: -19.7 kB (1%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
@ItsJonQ @jasmussen any thoughts here? |
|
I have been rekt by this so many times! .input-control, // Upstream name is `.regular-text`.
input[type="text"],
input[type="search"],
input[type="radio"],
input[type="tel"],
input[type="time"],
input[type="url"],
input[type="week"],
input[type="password"],
input[type="checkbox"],
input[type="color"],
input[type="date"],
input[type="datetime"],
input[type="datetime-local"],
input[type="email"],
input[type="month"],
input[type="number"],
select,This is a wonderful update @youknowriad Any suggestions for a good way to test for regressions? (Perhaps specific things to look for?) Thanks! |
|
From what I can tell, and in my careful testing, I can see only upsides and no downsides to this. I'm testing in an opinionated theme with a crazy editor style and things work well. But I do want to echo Q's thought: is there anything in particular to look for? |
|
Basically, the idea is to check how inputs, checkboxes, radio buttons look across the UI. |
|
Yep, so far that's what I tested and it worked well for me. I'm happy to approve, depending on how much testing you feel this needs. |
|
Please do approve, I'll continue my own testing too and merge. |
jasmussen
approved these changes
May 29, 2020
|
Let's try this. |
1 task
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the weekend, I played a little bit with Gutenberg packages outside WordPress and of the struggles I had is that most form control components relies on some kind of assumed styles that come from WordPress Core (or Gutenberg reset mixin).
This PR tries to embed these styles in the components them selves making them more reusable. It also removes the global reset for inputs, checkboxes... so it's one of those PRs where we'll be on a better position code quality wise but we need to be very careful with testing before merging.