-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/plugin document setting panel name #22763
Fix/plugin document setting panel name #22763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, thank you for proposing this improvement.
There is one file that was removed, I assume by accident. Otherwise, it looks good and should be good to go once my code style changes are applied to conform with WordPress guidelines.
docs/designers-developers/developers/slotfills/plugin-document-setting-panel.md
Outdated
Show resolved
Hide resolved
docs/designers-developers/developers/slotfills/plugin-document-setting-panel.md
Outdated
Show resolved
Hide resolved
@@ -1,118 +0,0 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this change is intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that! I've readded the file from master
…-setting-panel.md Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
…-setting-panel.md Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
…yanwelcher/gutenberg into fix/plugin-document-setting-panel-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thank you for quick improvements :)
@gziolo I found a couple of small items that I addressed. |
Description
This PR is a first pass at close #22049
How has this been tested?
Types of changes
Instead of combining the context.name and potentially missing ownProps.name. I have update the logic to use context.name only if ownProps.name is not defined. This will address the issue of the panel being referenced as
plugin-slug/undefined
if there is noname
property passed to thePluginDocumentSettingPanel
component.Checklist: