Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: Update Rich Image Icons #22819

Merged
merged 5 commits into from
Jun 8, 2020
Merged

Image: Update Rich Image Icons #22819

merged 5 commits into from
Jun 8, 2020

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Jun 2, 2020 •
edited
Loading

Description

Updates the icons in rich-image with the new ones from #22593

How has this been tested?

Add image block, view new edit icons, also check crop.

Screenshots

image

image

image

image

You can ignore the change aspect icon since it is being removed in #22817

Types of changes

Fixes #22570

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ajlende ajlende self-assigned this Jun 2, 2020
@ajlende ajlende added [Block] Image Affects the Image Block [Type] Enhancement A suggestion for improvement. labels Jun 2, 2020
@ajlende ajlende changed the title Update Rich Image Icons Image: Update Rich Image Icons Jun 2, 2020
ellatrix
ellatrix approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rebase and merge

@ellatrix ellatrix merged commit 2f3ea7b into WordPress:master Jun 8, 2020
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 8, 2020
@ajlende ajlende deleted the fix/rich-image-icons branch June 8, 2020 18:39
This was referenced Jun 24, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees

@ajlende ajlende

Labels
[Block] Image Affects the Image Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 8.4
Development

Successfully merging this pull request may close these issues.

Update image editing icons
2 participants
@ajlende @ellatrix